Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #216

Open
c4-bot-7 opened this issue Mar 11, 2024 · 5 comments
Open

QA Report #216

c4-bot-7 opened this issue Mar 11, 2024 · 5 comments
Labels
bug Something isn't working edited-by-warden grade-b Q-06 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality

Comments

@c4-bot-7
Copy link
Contributor

See the markdown file with the details of this report here.
@c4-bot-7 c4-bot-7 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Mar 11, 2024
c4-bot-4 added a commit that referenced this issue Mar 11, 2024
@c4-bot-4
shealtielanz issue #216
ba72623
c4-bot-8 added a commit that referenced this issue Mar 11, 2024
@c4-bot-8
shealtielanz data for issue #216
5a71624
c4-bot-1 added a commit that referenced this issue Mar 11, 2024
@c4-bot-1
Report for issue #216 updated by shealtielanz
119f2ad
c4-bot-5 added a commit that referenced this issue Mar 11, 2024
@c4-bot-5
Report for issue #216 updated by shealtielanz
f4363df
c4-bot-1 added a commit that referenced this issue Mar 11, 2024
@c4-bot-1
Report for issue #216 updated by shealtielanz
4c2e1db
c4-bot-6 added a commit that referenced this issue Mar 11, 2024
@c4-bot-6
Report for issue #216 updated by shealtielanz
93254aa
c4-bot-10 added a commit that referenced this issue Mar 11, 2024
@c4-bot-10
Report for issue #216 updated by shealtielanz
2bf40fa
@c4-pre-sort
Copy link

GalloDaSballo marked the issue as sufficient quality report

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Mar 17, 2024
@trust1995
Copy link

L2 is invalid - the specs discuss onReceiveFlashloan() while warden points to receiveFlashloan() function.
L5 is useless suggestion without explaining the context in which slot0 is used.
Having said that, meets the bar for B grade.

@c4-judge
Copy link
Contributor

trust1995 marked the issue as grade-b

@shealtielanz
Copy link

hi @trust1995 you're correct but this still qualifies for a higher grade can you please check

@trust1995
Copy link

I've checked and confirmed my position.

@C4-Staff C4-Staff added the Q-06 label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working edited-by-warden grade-b Q-06 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@trust1995 @c4-judge @c4-pre-sort @C4-Staff @shealtielanz @code4rena-admin @c4-bot-7