chore: update to electron 16 (microsoft#137241)

* chore: bump [email protected] * chore: bump [email protected] * chore: enable render process reuse * Revert "watcher - use `type` property for crash reporter location" This reverts commit bfa488d. * Revert "watcher - enable crash reports on linux (microsoft#136264)" This reverts commit af26148. * chore: enable crashpad on linux * chore: bump [email protected] * chore: update api changes * chore: bump @vscode/[email protected] * spec: skip non-context aware module unittests * chore: fix perf hook integration with node environment * fix: adopt fs api changes * chore: fix integration tests * chore: bump [email protected] * chore: bump [email protected] * temp(macOS): kill test instances in OSS * Revert "temp(macOS): kill test instances in OSS" This reverts commit b0d796c. * chore: update chromium version for clang downloader * some 💄 changes * align with changes * adopt more fs.rm * 💄 * chore: bump @vscode/[email protected] * fix layers check to account for duplicated types from node.js * update todo for type casts * smoke - fix compile issue * chore: update module cache * watcher - fix unhandled rejection (fix microsoft#137416) * ci: update node version * enable stack dumping * update electron types to 16.x * chore: bump @vscode/[email protected] Refs microsoft#137496 * fix layer issue * add `AbortSignal` to core types * chore: update linux compile flags Refs electron/electron@797723e * ci: fix linux build * ci: update github ci cache * ci: fix remote build in github ci * ci: better fix for remote build * chore: bump azure cache * chore: fix merge conflict * :chore: update to [email protected] * chore: bump @vscode/[email protected] * ci: update to gcc-4.9 for remote Refs microsoft#137659 * ci: switch to buster for linux arm Refs microsoft#137927 * ci: fix build on linux arm64 * ci: fix arm client compiler toolchain Refs microsoft#137927 * chore: bump [email protected] * ci: fix compile flags for the c toolchain * chore: bump [email protected] * Add experimental dark mode flag (microsoft#139109) * Add experimental dark mode flag * Apply PR feedback * chore: bump [email protected] * chore: bump [email protected] Fixes microsoft#138792 Fixes microsoft#139300 * chore: experimental highlight API * smoke - fix compile issue * FIXME: custom ELECTRON_RUN_AS_NODE with node worker * Revert "chore: bump [email protected]" This reverts commit 5fd01cf. * Revert "Revert "chore: bump [email protected]"" This reverts commit a7f1b73. * chore: fix github linux workflow * chore: address review feedback * chore: bump [email protected] * ci: revert to stretch distro for linux arm Refs microsoft#137927 * ci: force build * chore: update yarn.lock * address feedback * Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker" This reverts commit 7b48fa3. * ci: fix remote folder build * chore: fix github linux ci * 🆙 `versionSpec` Co-authored-by: Benjamin Pasero <[email protected]> Co-authored-by: Raymond Zhao <[email protected]>
code-oss-dev · Feb 8, 2022 · d783f3e · d783f3e
1 parent 501081d
commit d783f3e
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 21 deletions.
diff --git a/automation/package.json b/automation/package.json
@@ -29,7 +29,7 @@
   "devDependencies": {
     "@types/mkdirp": "^1.0.1",
     "@types/ncp": "2.0.1",
-    "@types/node": "14.x",
+    "@types/node": "16.x",
     "@types/tmp": "0.2.2",
     "cpx2": "3.0.0",
     "npm-run-all": "^4.1.5",

diff --git a/automation/src/code.ts b/automation/src/code.ts
@@ -206,7 +206,7 @@ export class Code {
 						this.logger.log('Smoke test exit call did not terminate process after 10s, forcefully exiting the application...');
 
 						// no need to await since we're polling for the process to die anyways
-						treekill(this.mainProcess.pid, err => {
+						treekill(this.mainProcess.pid!, err => {
 							this.logger.log('Failed to kill Electron process tree:', err?.message);
 						});
 					}
@@ -217,7 +217,7 @@ export class Code {
 					}
 
 					try {
-						process.kill(this.mainProcess.pid, 0); // throws an exception if the process doesn't exist anymore.
+						process.kill(this.mainProcess.pid!, 0); // throws an exception if the process doesn't exist anymore.
 						await new Promise(resolve => setTimeout(resolve, 500));
 					} catch (error) {
 						done = true;

diff --git a/automation/yarn.lock b/automation/yarn.lock
@@ -21,10 +21,10 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.1.tgz#3b5c3a26393c19b400844ac422bd0f631a94d69d"
   integrity sha512-aK9jxMypeSrhiYofWWBf/T7O+KwaiAHzM4sveCdWPn71lzUSMimRnKzhXDKfKwV1kWoBo2P1aGgaIYGLf9/ljw==
 
-"@types/node@14.x":
-  version "14.14.43"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.43.tgz#26bcbb0595b305400e8ceaf9a127a7f905ae49c8"
-  integrity sha512-3pwDJjp1PWacPTpH0LcfhgjvurQvrZFBrC6xxjaUEZ7ifUtT32jtjPxEMMblpqd2Mvx+k8haqQJLQxolyGN/cQ==
+"@types/node@16.x":
+  version "16.11.6"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.6.tgz#6bef7a2a0ad684cf6e90fcfe31cecabd9ce0a3ae"
+  integrity sha512-ua7PgUoeQFjmWPcoo9khiPum3Pd60k4/2ZGXt18sm2Slk0W0xZTqt5Y0Ny1NyBiN1EVQ/+FaF9NcY4Qe6rwk5w==
 
 "@types/[email protected]":
   version "0.2.2"

diff --git a/integration/browser/package.json b/integration/browser/package.json
@@ -8,7 +8,7 @@
   },
   "devDependencies": {
     "@types/mkdirp": "^1.0.1",
-    "@types/node": "14.x",
+    "@types/node": "16.x",
     "@types/optimist": "0.0.29",
     "@types/rimraf": "^2.0.4",
     "@types/tmp": "0.1.0",

diff --git a/integration/browser/yarn.lock b/integration/browser/yarn.lock
@@ -33,10 +33,10 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-13.7.0.tgz#b417deda18cf8400f278733499ad5547ed1abec4"
   integrity sha512-GnZbirvmqZUzMgkFn70c74OQpTTUcCzlhQliTzYjQMqg+hVKcDnxdL19Ne3UdYzdMA/+W3eb646FWn/ZaT1NfQ==
 
-"@types/node@14.x":
-  version "14.14.43"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.43.tgz#26bcbb0595b305400e8ceaf9a127a7f905ae49c8"
-  integrity sha512-3pwDJjp1PWacPTpH0LcfhgjvurQvrZFBrC6xxjaUEZ7ifUtT32jtjPxEMMblpqd2Mvx+k8haqQJLQxolyGN/cQ==
+"@types/node@16.x":
+  version "16.11.6"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.6.tgz#6bef7a2a0ad684cf6e90fcfe31cecabd9ce0a3ae"
+  integrity sha512-ua7PgUoeQFjmWPcoo9khiPum3Pd60k4/2ZGXt18sm2Slk0W0xZTqt5Y0Ny1NyBiN1EVQ/+FaF9NcY4Qe6rwk5w==
 
 "@types/[email protected]":
   version "0.0.29"

diff --git a/smoke/package.json b/smoke/package.json
@@ -21,7 +21,7 @@
     "@types/mkdirp": "^1.0.1",
     "@types/mocha": "^8.2.0",
     "@types/ncp": "2.0.1",
-    "@types/node": "14.x",
+    "@types/node": "16.x",
     "@types/node-fetch": "^2.5.10",
     "@types/rimraf": "3.0.2",
     "npm-run-all": "^4.1.5",

diff --git a/smoke/yarn.lock b/smoke/yarn.lock
@@ -58,10 +58,10 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-13.11.0.tgz#390ea202539c61c8fa6ba4428b57e05bc36dc47b"
   integrity sha512-uM4mnmsIIPK/yeO+42F2RQhGUIs39K2RFmugcJANppXe6J1nvH87PvzPZYpza7Xhhs8Yn9yIAVdLZ84z61+0xQ==
 
-"@types/node@14.x":
-  version "14.14.43"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.43.tgz#26bcbb0595b305400e8ceaf9a127a7f905ae49c8"
-  integrity sha512-3pwDJjp1PWacPTpH0LcfhgjvurQvrZFBrC6xxjaUEZ7ifUtT32jtjPxEMMblpqd2Mvx+k8haqQJLQxolyGN/cQ==
+"@types/node@16.x":
+  version "16.11.6"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.6.tgz#6bef7a2a0ad684cf6e90fcfe31cecabd9ce0a3ae"
+  integrity sha512-ua7PgUoeQFjmWPcoo9khiPum3Pd60k4/2ZGXt18sm2Slk0W0xZTqt5Y0Ny1NyBiN1EVQ/+FaF9NcY4Qe6rwk5w==
 
 "@types/[email protected]":
   version "3.0.2"

diff --git a/unit/electron/index.js b/unit/electron/index.js
@@ -20,10 +20,6 @@ const net = require('net');
 const createStatsCollector = require('mocha/lib/stats-collector');
 const { applyReporter, importMochaReporter } = require('../reporter');
 
-// Disable render process reuse, we still have
-// non-context aware native modules in the renderer.
-app.allowRendererProcessReuse = false;
-
 const optimist = require('optimist')
 	.describe('grep', 'only run tests matching <pattern>').alias('grep', 'g').alias('grep', 'f').string('grep')
 	.describe('run', 'only run tests from <file>').string('run')