Lots of copy changes #2120
Open
Lots of copy changes #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyikriszta
reviewed
Oct 9, 2024
| @@ -340,12 +340,10 @@ en: | |||
| sign_up_as_coach: "Join us as a coach" | |||
| code_of_conduct: "code of conduct" | |||
| new: | |||
| intro: "We offer a welcoming, inclusive and learning-friendly environment, and have a zero tolerance policy towards any form of harassment or inappropriate behavior. Before you sign up, read our" | |||
| intro_html: "We provide a welcoming, inclusive, and supportive learning environment, with a strict zero-tolerance policy for any form of harassment or inappropriate behavior. Please take a moment to review our <a href='https://codebar.io/code-of-conduct'>code of conduct</a> before signing up." | |||
There was a problem hiding this comment.
Instead of hard coding the href of the links like this can we pass it in as a variable to the translation string? That way we can make use of the path helpers (where they are available) and if the path every changes we'll only have to update it in one place. Here's the Rails guide on how to pass variables to translation strings https://guides.rubyonrails.org/i18n.html#passing-variables-to-translations
PS. I forgot to do this is a couple of places myself 😳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also moved the placement of the donate button and made the font size 16px (and semi-bold) as it was 14 and the rest of the nav so didn't match up.