Fixed the way more-info urls are returned when listing all libraries #61
+60
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the part of the getExternalLibrariesList method which returns the 'more info' url for each library. The url would only be returned if a Github repo and owner were stored in the database under this library. - Added new fixture data for the tests of this bugfix. - Added functional tests.
fpapadopou
changed the title
|
Changes Unknown when pulling 40cfb47 on github-url-fix into * on master*. |
|
Tested and works: Libraries live: Libraries staging: Library live: Library staging: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog
the 'more info' url for each library. The url would only be returned
if a Github repo and owner were stored in the database under this
library.
Merge Process
Nothing special, just pull the code.
Testing Steps
Head over to codebender's libraries and look for
SparkFunBME280library.More infobutton shouldn't be available under the/librariespage or under the library view page. After this change theMore infobutton should show up in both places.What's the deal: This library is stored as an external library on eratosthenes. When adding an external library to eratosthenes from Github, the respective
github-ownerandgithub-repocolumns are filled in the database. Although the SparkFunBME280 library is a Github library, we had to make some changes to its file structure and upload it to eratosthenes using a zip file. We did however add amore-info-urlwhich points to the Github library. Due to the bug fixed in this PR, the Urls would never be returned, unless thegithub-ownerandgithub-repowere filled in eratosthenes' database.