Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.7 incompatible with simplecov 0.14.0 #180

Closed
bliof opened this issue Mar 17, 2017 · 2 comments
Closed

v1.0.7 incompatible with simplecov 0.14.0 #180

bliof opened this issue Mar 17, 2017 · 2 comments
Assignees

Comments

@bliof
Copy link
Contributor

bliof commented Mar 17, 2017

The gem doesn't work with the latest version of simplecov.

bundler: failed to load command: codeclimate-test-reporter (/opt/circleci/.rvm/gems/ruby-2.3.3/bin/codeclimate-test-reporter)
NoMethodError: undefined method `merge_resultset' for #<Hash:0x007f0e9fef8be8>
  /opt/circleci/.rvm/gems/ruby-2.3.3/gems/codeclimate-test-reporter-1.0.7/lib/code_climate/test_reporter/formatter.rb:96:in `block in merge_results'
  /opt/circleci/.rvm/gems/ruby-2.3.3/gems/codeclimate-test-reporter-1.0.7/lib/code_climate/test_reporter/formatter.rb:95:in `each'
  /opt/circleci/.rvm/gems/ruby-2.3.3/gems/codeclimate-test-reporter-1.0.7/lib/code_climate/test_reporter/formatter.rb:95:in `merge_results'
  /opt/circleci/.rvm/gems/ruby-2.3.3/gems/codeclimate-test-reporter-1.0.7/lib/code_climate/test_reporter/formatter.rb:24:in `format'
  /opt/circleci/.rvm/gems/ruby-2.3.3/gems/codeclimate-test-reporter-1.0.7/lib/code_climate/test_reporter.rb:19:in `run'
  /opt/circleci/.rvm/gems/ruby-2.3.3/gems/codeclimate-test-reporter-1.0.7/bin/codeclimate-test-reporter:21:in `<top (required)>'
  /opt/circleci/.rvm/gems/ruby-2.3.3/bin/codeclimate-test-reporter:22:in `load'
  /opt/circleci/.rvm/gems/ruby-2.3.3/bin/codeclimate-test-reporter:22:in `<top (required)>'

It will be worth to lock the dependency to a specific version that is supported (currently in the gemspec):

spec.add_runtime_dependency "simplecov"

Relates to:

@bliof bliof changed the title v1.0.7 incompatible with simplecov 1.14.0 v1.0.7 incompatible with simplecov 0.14.0 Mar 17, 2017
@gdiggs gdiggs assigned gdiggs and unassigned chrishulton Mar 17, 2017
@gdiggs
Copy link
Contributor

gdiggs commented Mar 17, 2017

Hey @bliof! Thanks for opening this issue. If you want to open a pull request, I'd happily merge it, but don't know when we will have time to address it. Additionally, we are starting work on a new test reporter (https://github.com/codeclimate/test-reporter) that will be ready soon and will replace this one. If you are interested in hearing when that is ready, we are tracking an issue here!

@dblandin
Copy link
Contributor

Looks like the update made in #181 rolled out with version v1.0.8 of the reporter yesterday.

Going to go ahead and close this issue. Thanks!

glebm added a commit to glebm/i18n-tasks that referenced this issue Jan 18, 2018
They depend on internal APIs, see:
codeclimate/ruby-test-reporter#180
codeclimate/ruby-test-reporter#181

This is a second rewrite of their test reporter but they don't plan on
fixing this bug because they are working on the third rewrite...

I'm tired of having to deal with CodeClimate breakages on all my
projects so I'll be moving away from it. If you know a good alternative,
**well-written**, with support for aggregating multiple test suites,
please comment on this commit message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants