Call static analysis finish endpoint after uploading files #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the static-analysis command in the CLI, such that it calls the staticanalysis/analyses/<external_id>/finish endpoint in the API after it uploads the necessary files. This endpoint schedules the static analysis task on the worker immediately. Fixes: #66 Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/issue66
branch
from
8f97b38
to
fbaccb6
Compare
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 95.46% 95.53% +0.06%
==========================================
Files 69 69
Lines 2427 2441 +14
==========================================
+ Hits 2317 2332 +15
+ Misses 110 109 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dana-yaish
reviewed
Jul 3, 2023
dana-yaish
reviewed
Jul 3, 2023
This commit also adds the response status code to the log after sending the finish signal. Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/issue66
branch
from
a2b515e
to
5e57104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the static-analysis command in the CLI, such that it calls the staticanalysis/analyses/<external_id>/finish endpoint in the API after it uploads the necessary files. This endpoint schedules the static analysis task on the worker immediately.
Fixes: #66