Use LabelAnalysisRequestResult object
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using the result as a dictionary we can use it as the object we wrap it into. There are 2 benefits to this: 1. It's cleaner to read 2. It does the fallback to `[]` if the api returns any of the values as `None`. This avoids a bug we saw yesterday when trying to concatenate list to None. We do the wrapping in labelanalysis, before passing it to the runner.
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 70 70
Lines 2475 2475
=======================================
Hits 2368 2368
Misses 107 107
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dana-yaish
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using the result as a dictionary we can use it as the object we wrap it into.
There are 2 benefits to this:
[]if the api returns any of the values asNone. This avoids a bug we saw yesterday when trying to concatenate list to None.We do the wrapping in labelanalysis, before passing it to the runner.