-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Report #388
Comments
Hi @superlopuh , Can you try changing the fetch depth, as explained here https://docs.codecov.com/docs/environment-specific-requirements#github-actions ? (That's newly documented as of a few days ago, it was missed when we switched to v4. |
Thank you for the suggestion. I tried it out in these two PRs: xdslproject/xdsl#2650 And the diff is still missing. |
Hi @superlopuh , Interesting , it still isn't finding your repo files. How are you calling the action? Is it in a normal job with the repo checked out? A standalone job? A Docker container? Some other way? :) |
I'm not sure that I understand your question, here's the action file: https://github.com/xdslproject/xdsl/blob/bd7ffdfa722561bb5bb501a5fc400229c3aff366/.github/workflows/ci-mlir.yml It runs on every PR and when merged to main. It runs on the GitHub CI, runs a bunch of tests, combines the coverage, and then uploads to CodeCov. |
One of the things I'm a little confused by is this message in the CodeCov website:
Which suggests that there's a different problem to the PR not being able to display the diff, but rather in how our coverage data is collected and uploaded. |
Hi @superlopuh You actually have two issues:
Let me address one at a time, please 🙏 |
For the first, can you please add |
Thank you! What is the best way to see whether it's helped? Is it to merge the PR and see if the changes are reflected on the codecov.io website? Or is there something I can see in the logs? Here are the logs for the run with the
I'm a little concerned by the fact that it can't find the codecov.yml in the root folder. |
@thomasrockhu-codecov I think I need to tag you in here. It's unclear to me why the CLI can't find the file network. Using the action. |
As recommended here: codecov/feedback#388 This PR makes it such that checkout fetches the two prior commits, to show the diff.
Hi @drazisil-codecov @thomasrockhu-codecov, any follow-up on this? I'd be happy with any pointers, I'm just not sure where to start looking. |
hi @superlopuh sorry I haven't gotten a chance to dig into this. I'll take a look over the weekend |
Thank you! |
I recently switched to
codecov/codecov-action@v4
, and since then I've not been seeing any line by line coverage, on the website or in any of the actions.Here is a recent example:
xdslproject/xdsl#2621
Here's the relevant action for that PR:
https://github.com/xdslproject/xdsl/actions/runs/9188980377/job/25269976878
And the config:
On the codecov website, I see this for every file:
How do we get code coverage back?
The text was updated successfully, but these errors were encountered: