⚡️ Speed up PandasSeries.to_spec()
by 116% in src/bentoml/_internal/io_descriptors/pandas.py
#8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
PandasSeries.to_spec()
insrc/bentoml/_internal/io_descriptors/pandas.py
📈 Performance improved by
116%
(1.16x
faster)⏱️ Runtime went down from
3.34 milliseconds
to1.55 millisecond
Explanation and details
Certainly! Here’s an optimized version of the code that maintains the same functionality but runs faster by reducing redundant operations and avoiding unnecessary dictionary operations.
Explanation of Optimizations
Removed Redundancy in
_convert_dtype
.None
is now checked first to immediately return"null"
, reducing checks for cases wherevalue
isNone
.str
andbool
into a single block since both simply convert the value to astr
type without any further processing.LazyType["ext.NpNDArray"]
beforenp.dtype
with the assumption that this type check could match before a more specificnp.dtype
.Improved Readability and Reduced Type Checks.
These optimizations reduce the number of condition checks and improve the structure of the function for faster execution.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 33 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests