⚡️ Speed up _determine_reference_key()
by 30% in libs/langchain/langchain/smith/evaluation/runner_utils.py
#27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_determine_reference_key()
inlibs/langchain/langchain/smith/evaluation/runner_utils.py
📈 Performance went up by
30%
(0.30x
faster)⏱️ Runtime went down from
13.60μs
to10.50μs
Explanation and details
(click to show)
The existing python program seems to be optimized at a good extent, but it can be rewritten as below to make it a bit faster by avoiding extra variable usage and avoiding calling list() unnecessarily.
This tweaked function has the same functionality as the original one but involves fewer operations.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
✅ 0 Passed − ⚙️ Existing Unit Tests
✅ 0 Passed − 🎨 Inspired Regression Tests
✅ 8 Passed − 🌀 Generated Regression Tests
(click to show generated tests)