⚡️ Speed up concat()
by 41% in hogvm/python/stl/__init__.py
#18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
concat()
inhogvm/python/stl/__init__.py
📈 Performance improved by
41%
(0.41x
faster)⏱️ Runtime went down from
3.30 milliseconds
to2.34 milliseconds
Explanation and details
###Why these changes?
_to_concat_arg
to be more efficient with its early returns._to_concat_arg
function to minimize function call overhead since it was simple and used in only one place.###Correctness
###How is this faster?
args
, but with lower constants contributing to improved performance.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 20 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests