⚡️ Speed up get_list()
by 39% in posthog/settings/utils.py
#2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
get_list()
inposthog/settings/utils.py
📈 Performance improved by
39%
(0.39x
faster)⏱️ Runtime went down from
201.59μs
to144.75μs
Explanation and details
The existing Python code is efficient, but you can make minimal changes by avoiding the strip() method if the text does not contain any leading or trailing spaces. Here you go.
This change only speeds things up if you know that most of your inputs will not have spaces around the commas. If the common case is that there are spaces around the commas, then the existing function is pretty optimal.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 19 Passed − 🌀 Generated Regression Tests
(click to show generated tests)