⚡️ Speed up QueryDateRange.interval_relativedelta()
by 43% in posthog/hogql_queries/utils/query_date_range.py
#25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
QueryDateRange.interval_relativedelta()
inposthog/hogql_queries/utils/query_date_range.py
📈 Performance improved by
43%
(0.43x
faster)⏱️ Runtime went down from
109 microseconds
to76.7 microseconds
Explanation and details
###Why these changes?
###Correctness
__init__
ensures only valid intervals are processed, preserving input constraints.interval_name
is recalculated accurately each time it's used without persisting unnecessary state.###How is this faster?
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 17 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests