⚡️ Speed up _sorted_property_reprs()
by 27% in posthog/hogql_queries/insights/utils/entities.py
#37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_sorted_property_reprs()
inposthog/hogql_queries/insights/utils/entities.py
📈 Performance improved by
27%
(0.27x
faster)⏱️ Runtime went down from
2.17 microseconds
to1.71 microseconds
Explanation and details
Why these changes?
isinstance
checks into a single dictionary lookup using the type of the property.lru_cache
for the_semantic_property_repr
function to avoid recomputing the representation for the same property multiple times.sorted()
function.Correctness
How is this faster?
lru_cache
to expedite repeated representation generation.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 2 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests