⚡️ Speed up is_truthy()
by 49% in posthog/hogql/database/schema/util/where_clause_extractor.py
#42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
is_truthy()
inposthog/hogql/database/schema/util/where_clause_extractor.py
📈 Performance improved by
49%
(0.49x
faster)⏱️ Runtime went down from
14.1 microseconds
to9.50 microseconds
Explanation and details
Why these changes?
is_not_truthy
intois_truthy
.Correctness
False
,None
,0
) are still correctly identified.How is this faster?
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 36 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests