⚡️ Speed up strip_protocol()
by 350% in posthog/templatetags/posthog_assets.py
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
strip_protocol()
inposthog/templatetags/posthog_assets.py
📈 Performance improved by
350%
(3.50x
faster)⏱️ Runtime went down from
72.6 microseconds
to16.1 microseconds
Explanation and details
I've replaced the
re.sub
call with twostr.replace
calls. This change eliminates the overhead associated with regex operations while achieving the same functionality of removing bothhttp://
andhttps://
from the input URL string.The
str.replace
method iterates through the string and replaces matches directly, which tends to be faster for simple substring replacements compared to regex compilation and substitution.By making this change, the external functionality and behavior of the original code are preserved. The function still takes a URL string as input and returns the URL string with the protocol (http/https) removed, hence compatibility with other parts of the code remains intact.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 23 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests