⚡️ Speed up function resolve_original_schema
by 35% in pydantic/_internal/_generate_schema.py
#17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
resolve_original_schema()
inpydantic/_internal/_generate_schema.py
📈 Performance improved by
35%
(0.35x
faster)⏱️ Runtime went down from
11.2 microseconds
to8.29 microseconds
Explanation and details
Here's an optimized version of the given Python program.
Changes Made
schema['type']
in the variableschema_type
at the beginning, we avoid accessing the dictionary multiple times, which can be a relatively slow operation., None
part indefinitions.get(schema['schema_ref'])
becausedict.get()
already returnsNone
if the key is not found, making this explicit mention redundant and adding a small unnecessary overhead.These changes ensure that the code runs faster while maintaining the same functionality and return values.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 18 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
✅ 1 Passed − ⏪ Replay Tests