⚡️ Speed up function is_deprecated_instance
by 11% in pydantic/_internal/_typing_extra.py
#28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
is_deprecated_instance()
inpydantic/_internal/_typing_extra.py
📈 Performance improved by
11%
(0.11x
faster)⏱️ Runtime went down from
21.0 microseconds
to18.8 microseconds
Explanation and details
To optimize the provided Python code, we can make use of a few techniques like reducing condition checks and avoiding runtime evaluations where possible. The usage of
tuple
andisinstance
can be optimized by simplifying the initialization of theDEPRECATED_TYPES
.Changes Explained.
Initialization of
DEPRECATED_TYPES
:isinstance(deprecated, type)
totype(deprecated) is type
for a small performance gain sincetype(deprecated)
is a direct comparison.Usage of
type(instance)
foris_deprecated_instance
:type(instance)
as opposed toisinstance(instance, DEPRECATED_TYPES)
can be faster when checking against a predefined set of types because it avoids the recursive nature ofisinstance
.This should enhance the performance by reducing the number of function calls and simplifying the conditional checks.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 0 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
✅ 43 Passed − ⏪ Replay Tests