⚡️ Speed up _to_str()
by 38% in rich/filesize.py
#26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_to_str()
inrich/filesize.py
📈 Performance improved by
38%
(0.38x
faster)⏱️ Runtime went down from
198 microseconds
to144 microseconds
Explanation and details
Sure! Here is an optimized version of the
_to_str
function.Here are the changes made to optimize the runtime.
enumerate
, we directly multiplyunit
bybase
in each iteration which saves the computation ofbase ** i
.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 18 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests