⚡️ Speed up Span.move() by 24% in rich/text.py

[codeflash-ai]

📄 Span.move() in rich/text.py

📈 Performance improved by 24% (0.24x faster)

⏱️ Runtime went down from 45.1 microseconds to 36.3 microseconds

Explanation and details

Certainly! To improve the performance of the given code, we need to focus on avoiding redundant operations and simplifying the logic where possible while maintaining the functionality intact. Here's the optimized version.

Note: The Span class was previously defined twice in your code, which is redundant and incorrect. I've consolidated the class definition accordingly.

Optimizations Made.

1. Class Consolidation: Removed the redundant Span class declaration.
2. Conditions Simplified: Optimized the conditional checks in methods like split and right_crop to reduce the number of comparisons and ensure early exits when applicable.
3. Direct Access: Removed the redundant unpacking of tuple elements in methods to reduce the overhead of variable reassignments. Instead, I used the properties directly.

By reducing redundancy and enhancing the conditional checks' efficiency, the updated code should generally perform better while maintaining the original functionality.

Correctness verification

The new optimized code was tested for correctness. The results are listed below.

✅ 106 Passed − ⚙️ Existing Unit Tests

(click to show existing tests)

- test_text.py

✅ 13 Passed − 🌀 Generated Regression Tests

(click to show generated tests)

# imports
from typing import NamedTuple, Optional, Tuple, Union

import pytest  # used for our unit tests
# function to test
from rich.style import Style

# unit tests

# Basic Functionality Tests
def test_move_positive_offset():
    span = Span(0, 5, "bold")
    moved_span = span.move(3)
    assert moved_span == Span(3, 8, "bold")

def test_move_negative_offset():
    span = Span(5, 10, "bold")
    moved_span = span.move(-3)
    assert moved_span == Span(2, 7, "bold")

# Edge Cases
def test_move_zero_offset():
    span = Span(0, 5, "bold")
    moved_span = span.move(0)
    assert moved_span == Span(0, 5, "bold")

def test_move_zero_length_span():
    span = Span(5, 5, "bold")
    moved_span = span.move(3)
    assert moved_span == Span(8, 8, "bold")

# Large Offsets
def test_move_large_positive_offset():
    span = Span(0, 5, "bold")
    moved_span = span.move(1000)
    assert moved_span == Span(1000, 1005, "bold")

def test_move_large_negative_offset():
    span = Span(1000, 2000, "bold")
    moved_span = span.move(-500)
    assert moved_span == Span(500, 1500, "bold")

# Boundary Conditions
def test_move_leading_to_negative_indices():
    span = Span(0, 5, "bold")
    moved_span = span.move(-10)
    assert moved_span == Span(-10, -5, "bold")

def test_move_leading_to_very_large_indices():
    large_offset = 2**31 - 1
    span = Span(0, 5, "bold")
    moved_span = span.move(large_offset)
    assert moved_span == Span(large_offset, large_offset + 5, "bold")

# Performance and Scalability
def test_move_large_span():
    span = Span(0, 10**6, "bold")
    moved_span = span.move(1)
    assert moved_span == Span(1, 10**6 + 1, "bold")

def test_move_multiple_sequential_moves():
    span = Span(0, 5, "bold")
    span = span.move(1)
    span = span.move(2)
    span = span.move(-3)
    assert span == Span(0, 5, "bold")

# Complex Scenarios
def test_move_overlap_with_other_spans():
    span1 = Span(0, 5, "bold")
    span2 = Span(3, 8, "italic")
    moved_span = span1.move(3)
    assert moved_span == Span(3, 8, "bold")

def test_move_non_integer_offsets():
    span = Span(0, 5, "bold")
    with pytest.raises(TypeError):
        span.move(0.5)
    with pytest.raises(TypeError):
        span.move('a')

🔘 (none found) − ⏪ Replay Tests