Skip to content

Commit

Permalink
Enable event reporter 2.0 by default + return rate limiter (#62)
Browse files Browse the repository at this point in the history
* enable event reporter by default

* add comment

* update argo-cd image

* fix docs

* disable reporter in tests

* align versions
  • Loading branch information
yaroslav-codefresh authored Mar 5, 2024
1 parent 202f17b commit 0c60db0
Show file tree
Hide file tree
Showing 8 changed files with 34 additions and 7 deletions.
8 changes: 5 additions & 3 deletions charts/argo-cd/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
apiVersion: v2
appVersion: v2.9-2024.2.29-0f82ce2ec
appVersion: v2.9-2024.3.5-80c3e7225
kubeVersion: ">=1.23.0-0"
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 5.53.12-5-cap-2.9-2024.2.29-0f82ce2ec
version: 5.53.12-6-cap-2.9-2024.3.5-80c3e7225
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
sources:
Expand All @@ -27,4 +27,6 @@ annotations:
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Upgrade Argo CD to v2.9-2024.2.15-cc783d89f. Getting application version configuration from the Codefresh API.
description: Enable Event Reporter 2.0 by default with 3 replicas.
- kind: changed
description: Change ArgoCD image to 2.9-2024.3.5-80c3e7225 which includes event-reporter rate-limiter.
4 changes: 2 additions & 2 deletions charts/argo-cd/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ NAME: my-release
| eventReporter.containerSecurityContext | object | See [values.yaml] | Event reporter container-level security context |
| eventReporter.dnsConfig | object | `{}` | [DNS configuration] |
| eventReporter.dnsPolicy | string | `"ClusterFirst"` | Alternative DNS policy for event reporter pods |
| eventReporter.enabled | bool | `false` | |
| eventReporter.enabled | bool | `true` | |
| eventReporter.env | list | `[]` | Environment variables to pass to event reporter |
| eventReporter.envFrom | list | `[]` (See [values.yaml]) | envFrom to pass to event reporter |
| eventReporter.extraArgs | list | `[]` | Additional command line arguments to pass to event reporter |
Expand Down Expand Up @@ -478,7 +478,7 @@ NAME: my-release
| eventReporter.terminationGracePeriodSeconds | int | `30` | terminationGracePeriodSeconds for container lifecycle hook |
| eventReporter.tolerations | list | `[]` (defaults to global.tolerations) | [Tolerations] for use with node taints |
| eventReporter.topologySpreadConstraints | list | `[]` (defaults to global.topologySpreadConstraints) | Assign custom [TopologySpreadConstraints] rules to the event reporter |
| eventReporter.version | string | `"v1"` | |
| eventReporter.version | string | `"v2"` | |
| eventReporter.volumeMounts | list | `[]` | Additional volumeMounts to the event reporter main container |
| eventReporter.volumes | list | `[]` | Additional volumes to the event reporter pod |
| extraObjects | list | `[]` | Array of extra K8s manifests to deploy |
Expand Down
5 changes: 5 additions & 0 deletions charts/argo-cd/ci/default-values.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Test with default values
crds:
keep: false

# these tests only support vanilla argo-cd
# do not work for event reporter component
eventReporter:
enabled: false
5 changes: 5 additions & 0 deletions charts/argo-cd/ci/extension-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,8 @@ server:
value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension.tar.gz
- name: EXTENSION_CHECKSUM_URL
value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension_checksums.txt

# these tests only support vanilla argo-cd
# do not work for event reporter component
eventReporter:
enabled: false
5 changes: 5 additions & 0 deletions charts/argo-cd/ci/external-redis-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,8 @@ redis-ha:
externalRedis:
host: "redis-master.redis.svc.cluster.local"
password: "argocd"

# these tests only support vanilla argo-cd
# do not work for event reporter component
eventReporter:
enabled: false
5 changes: 5 additions & 0 deletions charts/argo-cd/ci/ha-autoscaling-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,8 @@ repoServer:
autoscaling:
enabled: true
minReplicas: 2

# these tests only support vanilla argo-cd
# do not work for event reporter component
eventReporter:
enabled: false
5 changes: 5 additions & 0 deletions charts/argo-cd/ci/ha-static-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,8 @@ server:

repoServer:
replicas: 2

# these tests only support vanilla argo-cd
# do not work for event reporter component
eventReporter:
enabled: false
4 changes: 2 additions & 2 deletions charts/argo-cd/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3333,11 +3333,11 @@ notifications:

eventReporter:
# Enabled we need to skip argo-cd chart tests for this component
enabled: false
enabled: true
# Version we need to dynamically switch between old and new version
# one will be just hanging and the second one working
# possible values: v1, v2
version: v1
version: v2
name: event-reporter
## Amount of replicas for event reporting sharding
replicas: 3
Expand Down

0 comments on commit 0c60db0

Please sign in to comment.