Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyperclient v0.8.3 breaks compatibility with Faraday < v0.9 #117

Closed
a-maas opened this issue May 16, 2017 · 2 comments
Closed

hyperclient v0.8.3 breaks compatibility with Faraday < v0.9 #117

a-maas opened this issue May 16, 2017 · 2 comments
Assignees
@ivoanjo

Comments

@a-maas
Copy link

a-maas commented May 16, 2017

Hyperclient v0.8.3 implements FlatParamsEncoder, which was implemented in Faraday v0.9 and above. This breaks compatibility with Faraday less than v0.9. I wanted to see if this change was intensional, and is so, if you'd consider adding the minimum version of faraday in your gemspec so that bundler can figure out what version of hyperclient to use based on the app's version of Faraday.
@ivoanjo
Copy link
Contributor

ivoanjo commented May 16, 2017

Yes, you're absolutely right! The FlatParamsEncoder is required, otherwise in parameters would be dropped in some cases --- when there were more than a value for the same parameter.

I will update the gemspec and put out a new release, thanks for reporting.

ivoanjo added a commit that referenced this issue May 16, 2017
@ivoanjo
Require Faraday >= 0.9.0 in gemspec
4e8b146 
In #115 we started configuring Faraday to use the FlatParamsEncoder to
avoid an issue with dropped parameters when building a request url.

The FlatParamsEncoder was only added on Faraday 0.9.0 and thus we must
require it explicitly, otherwise clients may get confusing messages
after upgrading to hyperclient 0.8.4.

Fixes #117
ivoanjo added a commit that referenced this issue May 16, 2017
@ivoanjo
Require Faraday >= 0.9.0 in gemspec
947232f 
In #115 we started configuring Faraday to use the FlatParamsEncoder to
avoid an issue with dropped parameters when building a request url.

Unfortunately, as FlatParamsEncoder was only added on Faraday 0.9.0
we should require that version as a minimum, otherwise clients may get
confusing error messages after upgrading to the latest hyperclient
version.

Fixes #117
@ivoanjo ivoanjo mentioned this issue May 16, 2017
Merged
@txus txus removed the in progress label May 16, 2017
@a-maas
Copy link
Author

a-maas commented May 16, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivoanjo ivoanjo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@txus @ivoanjo @a-maas