Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate-page #414

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

michalsn
Copy link
Member

Description
This PR fixes a few issues with the current generate-page script implementation, described below.

I have noticed a two things:

  • information about Missing keys that are in a nested array is not displayed
  • there is no information about missing files (if there are any), therefore missing files are not considered when calculating the overall translation percentage for the locale

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Oct 22, 2023

The code looks good without going through it too thoroughly. Would you please share a couple before and after pics?

@michalsn
Copy link
Member Author

Sure, here you go.

Before:
obraz
obraz

After:
obraz
obraz

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you @michalsn

@paulbalandan paulbalandan merged commit 9cf5e08 into codeigniter4:develop Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants