-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tr] Update Turkish Translations #429
Conversation
@obozdag, could you please review these updates to the Turkish translations and provide your feedback? Thanks. |
Thanks for your effort. I am checking. Looks nice. Meanwhile can you please add the missing files to Turkish? You can find the full list at https://github.com/codeigniter4/CodeIgniter4/tree/develop/system/Language/en address. |
There are some missing translations.
https://github.com/codeigniter4/translations/actions/runs/7455231871/job/20366207708?pr=429 |
@obozdag, as you suggested, I have added the missing Turkish translation files. Could you please review these new additions? Thanks. |
@aslanutku I have listed some reviews below. Can you please check? For the word "string" there were three different translations (dize, dizgi, dizge). For consistency we can choose one. I prefer "dizgi". For the word "handler" we can use "işleyici" as you did in some translations. Language/tr/Cache.php 'invalidHandlers' => 'Cache config must have an array of $validHandlers.', 'noBackup' => 'Cache config must have a handler and backupHandler set.', Language/tr/Core.php 'noHandlers' => '"{0}" must provide at least one Handler.', Language/tr/Cookie.php 'invalidHostPrefix' => 'Using the "__Host-" prefix must be set with the "Secure" flag, must not have a "Domain" attribute, and the "Path" is set to "/".', 'unknownCookieInstance' => 'Cookie object with name "{0}" and prefix "{1}" was not found in the collection.', Language/tr/Core.php 'copyError' => 'An error was encountered while attempting to replace the file "{0}". Please make sure your file directory is writable.', 'missingExtension' => 'The framework needs the following extension(s) installed and loaded: "{0}".', Language/tr/Encryption.php 'noHandlerAvailable' => 'Unable to find an available "{0}" encryption handler.', Language/tr/HTTP.php 'invalidSSLKey' => 'Cannot set SSL Key. "{0}" is not a valid file.', 'invalidNegotiationType' => '"{0}" is not a valid negotiation type. Must be one of: media, charset, encoding, language.', 'unknownStatusCode' => 'Unknown HTTP status code provided with no message: {0}', 'segmentOutOfRange' => 'Request URI segment is out of range: "{0}"', 'localeNotSupported' => 'Locale is not supported: {0}', 'disallowedAction' => 'The action you requested is not allowed.', 'uploadErrIniSize' => 'The file "%s" exceeds your upload_max_filesize ini directive.', 'uploadErrFormSize' => 'The file "%s" exceeds the upload limit defined in your form.', 'uploadErrPartial' => 'The file "%s" was only partially uploaded.', 'uploadErrCantWrite' => 'The file "%s" could not be written on disk.', 'uploadErrUnknown' => 'The file "%s" was not uploaded due to an unknown error.', 'invalidSameSiteSetting' => 'The SameSite setting must be None, Lax, Strict, or a blank string. Given: {0}', Language/tr/Images.php 'saveFailed' => 'Unable to save the image. Please make sure the image and file directory are writable.', 'exifNotSupported' => 'Reading EXIF data is not supported by this PHP installation.', Language/tr/Migrations.php 'migHelpLatest' => "\t\tMigrates database to latest available migration.", 'migHelpCurrent' => "\t\tMigrates database to version set as 'current' in configuration.", 'migHelpVersion' => "\tMigrates database to version {v}.", 'migHelpRollback' => "\tRuns all migrations 'down' to version 0.", 'migCreate' => "\tCreates a new migration named [name]", 'migNumberError' => 'Migration number must be three digits, and there must not be any gaps in the sequence.', 'rollingBack' => 'Rolling back migrations to batch: ', Language/tr/Pager.php 'invalidTemplate' => '"{0}" is not a valid Pager template.', Language/tr/Publisher.php 'fileNotAllowed' => '"{0}" fails the following restriction for "{1}": {2}', 'publishMissing' => 'No Publisher classes detected in {0} across all namespaces.', 'publishSuccess' => '"{0}" published {1} file(s) to "{2}".', Language/tr/Router.php 'invalidParameter' => 'A parameter does not match the expected type.', 'missingDefaultRoute' => 'Unable to determine what should be displayed. A default route has not been specified in the routing file.', 'invalidDynamicController' => 'A dynamic controller is not allowed for security reasons. Route handler: "{0}"', 'invalidControllerName' => 'The namespace delimiter is a backslash (), not a slash (/). Route handler: "{0}"', Language/tr/Security.php 'invalidSameSiteSetting' => 'The SameSite setting must be None, Lax, Strict, or a blank string. Given: {0}', Language/tr/Session.php 'missingDatabaseTable' => '"sessionSavePath" must have the table name for the Database Session Handler to work.', 'invalidSameSiteSetting' => 'The SameSite setting must be None, Lax, Strict, or a blank string. Given: {0}', |
@obozdag, I have made the updates to the translations based on the feedback provided. Could you please take a moment to review them? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aslanutku Thanks for the updates. After you update the last reviews I have added on the files we can merge.
Language/tr/Core.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please consider the following changes?
'copyError' => 'Dosya "{0}" kaydedilirken bir hata oluştu. Lütfen dosya dizininizin yazılabilir olduğundan emin olun.',
'missingExtension' => 'Çatı (framework) için aşağıdaki eklentinin(lerin) yüklü ve etkin olması gerekir: "{0}".',
'noHandlers' => '"{0}", en az bir handler sağlamalıdır.',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please consider the following changes?
'invalidHandlers' => 'Önbellek yapılandırması, $validHandlers (geçerli handlerlar) dizisi içermelidir.',
'noBackup' => 'Önbellek yapılandırması, bir handler ve yedek handler (backupHandler) kümesi belirlemelidir.',
Language/tr/Cache.php
Outdated
'noBackup' => 'Önbellek ayarlarının bir işleyicisinin olması ve backupHandler\'inin belirlenmesi gerekir.', | ||
'handlerNotFound' => 'Önbellek ayarlarının işleyicisi veya yedek işleyicisi geçersiz.', | ||
'unableToWrite' => 'Önbellek, "{0}" konumuna yazamıyor.', | ||
'invalidHandlers' => 'Önbellek yapılandırması, geçerli $validHandlers dizgisi içermelidir.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For array we use "dizi" for string we use "dizgi". Here it is an array, so the translation should be "Önbellek yapılandırması, geçerli bir $validHandlers dizisi içermelidir."
Language/tr/Router.php
Outdated
'invalidParameter' => 'Bir parametre beklenen türle eşleşmiyor.', | ||
'missingDefaultRoute' => 'Ne görüntüleneceği belirlenemiyor. Yönlendirme dosyasında varsayılan bir rota belirtilmemiş.', | ||
'invalidDynamicController' => 'Güvenlik nedeniyle dinamik bir kontrolcüye izin verilmiyor. Rota işleyici: "{0}"', | ||
'invalidControllerName' => 'Ad alanı ayırıcısı ters eğik çizgidir (), düz eğik çizgi (/) değildir. Rota işleyici: "{0}"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Ad alanı ayırıcısı ters eğik çizgidir (), düz eğik çizgi (/) değildir. Rota işleyici: "{0}"', should be 'Ad alanı ayırıcısı ters eğik çizgidir (), düz eğik çizgi (/) değildir. Rota işleyici: "{0}"', the backslash is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Ad alanı ayırıcısı ters eğik çizgidir (\), düz eğik çizgi (/) değildir. Rota işleyici: "{0}"',
Language/tr/Session.php
Outdated
'writeProtectedSavePath' => 'Oturum: Ayarlarda belirtilen kayıt yolu "{0}" PHP işlemi tarafından yazılabilir değil.', | ||
'emptySavePath' => 'Oturum: Kayıt yolu belirtilmemiş.', | ||
'invalidSavePathFormat' => 'Oturum: Geçersiz Redis kayıt yolu biçimi: {0}', | ||
'missingDatabaseTable' => 'Veritabanı Oturum İşleyicisinin (Database Session Handler) çalışması için "sessionSavePath" bir tablo adı içermelidir.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Veritabanı Oturum İşleyicisinin (Database Session Handler) çalışması için "sessionSavePath" bir tablo adı içermelidir.',
should be
'Veri tabanı Oturum İşleyicisinin (Database Session Handler) çalışması için "sessionSavePath" bir tablo adı içermelidir.',
For the consistency we should use "veri tabanı" for database in all translations. In my last review I also misused. Sorry.
Language/tr/Database.php
Outdated
'invalidAllowedFields' => 'İzin verilen alanlar model için belirtilmeli: "{0}"', | ||
'emptyDataset' => '{0} için veri yok.', | ||
'emptyPrimaryKey' => '{0} yapmaya çalışırken birincil anahtar tanımlı değil.', | ||
'failGetFieldData' => 'Veritabanından alan verileri alınamadı.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Veritabanından alan verileri alınamadı.',
should be
'Veri tabanından alan verileri alınamadı.',
All "veritabanı" words should be written separately as "veri tabanı".
@obozdag, I've updated the translations based on the latest feedback received. Could you please take a look at them again when you have a moment? Thanks. |
@paulbalandan |
I think this error is related to el language not tr (Turkish) |
@obozdag The code style errors are due to a bug in php-cs-fixer. If you want to use php-cs-fixer to fix the coding style, please fix the version: --- a/composer.json
+++ b/composer.json
@@ -12,7 +12,7 @@
"ext-tokenizer": "*",
"codeigniter/coding-standard": "^1.1",
"codeigniter4/codeigniter4": "4.x-dev",
- "friendsofphp/php-cs-fixer": "^3.1",
+ "friendsofphp/php-cs-fixer": "~3.46.0",
"nexusphp/cs-config": "^3.3",
"phpunit/phpunit": "^9.5"
}, |
@kenjis Can you please accept these updates and merge them. |
thank you, @aslanutku and @obozdag |
Description
I have updated the existing Turkish translations and added the missing parts.
Checklist: