-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/migrate booking/[uid] page #151
Conversation
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
apps/web/app/layout.tsx
Outdated
@@ -0,0 +1,12 @@ | |||
export const metadata = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this file needed?
}; | ||
|
||
export async function getRecurringBookings(recurringEventId: string | null) { | ||
if (!recurringEventId) return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ return null; }
// @TODO: right now bookings with seats doesn't save every description that its entered by every user | ||
delete bookingInfo.description; | ||
} else { | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just invert the check and return if null, I find the choice of the expression weird
b3c2a28
to
e9b19d8
Compare
e9b19d8
to
41ed3e8
Compare
What does this PR do?
Fixes # (issue)
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist