Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-2055 Migrate /availability/index page #45

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

hbjORbj
Copy link

@hbjORbj hbjORbj commented Oct 16, 2023

What does this PR do?

  • Migrate apps/web/pages/availability/index.tsx page into apps/web/app/availability-1/page.tsx and apps/web/app/availability-1/layout.tsx.
  • Makes apps/web/pages/availability/index.tsx a client component.
  • Use Next13-compatible trpc client defined in @calcom/web/app/_trpc/client rather than the incompatible trpc client defined in @calcom/trpc/react.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Navigate to http://localhost:3000/availability-1 and test various mutations such as creating or editing

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "INT-2055 Migrate `/availability/index` page". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@hbjORbj hbjORbj changed the base branch from trpc-migrate to intuita/app-router-migration October 26, 2023 17:05
@hbjORbj hbjORbj merged commit 5e1a0f6 into intuita/app-router-migration Oct 26, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant