Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the locale from window.calNewLocale #7

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

grzpab
Copy link

@grzpab grzpab commented Sep 26, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Extract the locale from `window.calNewLocale`". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

apps/web/pages/_app.tsx Outdated Show resolved Hide resolved
apps/web/pages/_document.tsx Outdated Show resolved Hide resolved
@grzpab grzpab merged commit 81ff21f into gpp/newLocale Sep 26, 2023
1 of 2 checks passed
@grzpab grzpab deleted the gpp/newLocaleOverHtmlLang branch September 26, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants