Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx error when building with oneAPI release compiler #497

Conversation

muhammad-tanvir-1211
Copy link
Collaborator

This PR fixes an error seen from googlebench and gtest (warning in this case) that explicit comparison with NaN is not allowed in fast precision mode.

@pgorlani
Copy link
Collaborator

If the purpose of the patch is removing the warning during the unit test/benchmark compilation, it would be better to set -Wno-tautological-constant-compare in test/CMakeLists.txt and benchmark/portblas/CMakeLists.txt.

-ffp-model=precise flag is an umbrella option that could have side consequences on many aspects since it "disables optimizations that are not value-safe on floating-point data".

@muhammad-tanvir-1211 muhammad-tanvir-1211 merged commit 2f149cb into codeplaysoftware:master Feb 27, 2024
3 checks passed
@muhammad-tanvir-1211 muhammad-tanvir-1211 deleted the fix_icpx_compilation branch April 11, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants