Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test paths used in configuration loader #3781

Closed
jsjoeio opened this issue Jul 14, 2021 · 1 comment
Closed

Test paths used in configuration loader #3781

jsjoeio opened this issue Jul 14, 2021 · 1 comment
Labels
testing Anything related to testing
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 14, 2021

Follow-up item from #3760

Testing the paths like this might not catch anything since we'd be copying any mistakes we already have.

The ideal might be to:

  1. Ensure that each path resolves to a real Node module.
  2. Check VS Code's workbench.html and make sure we have the same paths we do (maybe could do this later).

@code-asher

@jsjoeio jsjoeio added the testing Anything related to testing label Jul 14, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Jul 14, 2021
@stale
Copy link

stale bot commented Jan 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Jan 11, 2022
@stale stale bot closed this as completed Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

No branches or pull requests

1 participant