-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add registerRequireOnSelf on function #3760
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3760 +/- ##
==========================================
+ Coverage 62.10% 62.60% +0.50%
==========================================
Files 36 36
Lines 1863 1872 +9
Branches 378 379 +1
==========================================
+ Hits 1157 1172 +15
+ Misses 600 595 -5
+ Partials 106 105 -1
Continue to review full report at Codecov.
|
65c4f29
to
7a26391
Compare
85981ad
to
9c9630f
Compare
@code-asher refactored! I hope I understood your suggestions. Feel free to nitpick/correct again if I didn't! |
Ah, that's super frustrating :( Before all the refactoring, code coverage had increased. And now that I removed a bunch, I guess it's gone down. The joy of code-coverage + testing! @code-asher I'll mark as draft and add more tests, but do you mind reviewing still? |
8da08ac
to
31f0fd9
Compare
All in all, I think this will actually be a lot better than the first iteration. |
Eventually when this gets to a good state and is approved and merged, the |
14845f4
to
911cb03
Compare
This adds a new function called
registerRequireOnSelf
tovscode.ts
. We do this so that we can extract this logic into a function, which makes it easier to test.Screenshot
Screen.Recording.2021-07-12.at.12.10.24.PM.mov
Fixes N/A
TODOs