docker: Allow passing $DOCKER_USER to set the username in the container #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
force-pushed
the
docker-user-1c5d
branch
from
9448272
to
e73b360
Compare
|
At first glance, this looks fantastic! It solves a definitely minor but important problem. Thanks @nhooyr! |
code-asher
reviewed
Aug 25, 2020
nhooyr
force-pushed
the
docker-user-1c5d
branch
3 times, most recently
from
88e33a5
to
d4828ae
Compare
Merged
nhooyr
force-pushed
the
docker-user-1c5d
branch
2 times, most recently
from
a123f29
to
1d415f3
Compare
nhooyr
force-pushed
the
docker-user-1c5d
branch
from
1d415f3
to
8eb39e3
Compare
|
Should be good now. |
nhooyr
force-pushed
the
docker-user-1c5d
branch
2 times, most recently
from
7bac1d6
to
8317b98
Compare
code-asher
reviewed
Aug 26, 2020
|
Actually no I see that gets deleted. |
|
Weird. 🤔 |
|
Can confirm the exec issue, debugging. |
|
Ah, you need to set pass |
Needs to be reflected in the documentation and the dockerhub description now. Closes #881
This way, building a standalone release locally and putting it in the release contianer for testing is less likely to break.
nhooyr
force-pushed
the
docker-user-1c5d
branch
from
8317b98
to
4b7c2ea
Compare
|
Ahhhhh yup that worked! Now I'm getting Is that happening to you? |
|
Huh, no, my shell opened fine. |
|
i.e |
|
We discussed on slack and the error is unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be reflected in the documentation and the dockerhub description
now.
Closes #881
cc @avaidyam