-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(publish): update cdrci fork in brew-bump.sh #3468
Conversation
32409a7
to
6305d5e
Compare
Codecov Report
@@ Coverage Diff @@
## main #3468 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 35 35
Lines 1709 1709
Branches 379 379
=======================================
Hits 1012 1012
Misses 559 559
Partials 138 138 Continue to review full report at Codecov.
|
acb992a
to
1c39518
Compare
@code-asher ready for a second review |
This PR fixes the homebrew
brew-bump.sh
step which runs when we publish a new release.Additional Context
Problem
When we publish a new release, we run a script to bump the formula for code-server on homebrew. The script works using
cdrci
's GitHub token (secret in repo) so that the PR comes from them and not a maintainer.The problem is
bump-formula-pr
uses the user'shomebrew-core
fork.This means we need to ensure the fork is up-to-date.
To do that, we need to pull the remote and push the changes to the fork before running
bump-formula-pr
.We tried to see if it would "just work" by pulling and pushing, but the push command asks for a username and password.
Solution
You can get around this with
--all
. We found this solution here.Changes
brew-bump.sh
Screenshots
Tested locally and this new approach should work.
Checklist
CHANGELOG.md
Fixes #3444