Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): update cdrci fork in brew-bump.sh #3468

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 24, 2021

This PR fixes the homebrew brew-bump.sh step which runs when we publish a new release.

Additional Context

Problem

When we publish a new release, we run a script to bump the formula for code-server on homebrew. The script works using cdrci's GitHub token (secret in repo) so that the PR comes from them and not a maintainer.

The problem is bump-formula-pr uses the user's homebrew-core fork.

This means we need to ensure the fork is up-to-date.

To do that, we need to pull the remote and push the changes to the fork before running bump-formula-pr.

We tried to see if it would "just work" by pulling and pushing, but the push command asks for a username and password.

Solution

You can get around this with --all. We found this solution here.

This has the advantage that the password won't be visible in the process list too.

Changes

  • update brew-bump.sh

Screenshots

Tested locally and this new approach should work.
image

Checklist

  • add to repo secrets
  • tested locally
  • updated CHANGELOG.md

Fixes #3444

@jsjoeio jsjoeio added this to the 3.11.0 milestone May 24, 2021
@jsjoeio jsjoeio added the ci Issues related to ci label May 24, 2021
@jsjoeio jsjoeio self-assigned this May 24, 2021
@jsjoeio jsjoeio changed the title title here fix(publish): update cdrci fork in brew-bump.sh May 24, 2021
@jsjoeio jsjoeio force-pushed the jsjoeio/fix-3444 branch 2 times, most recently from 32409a7 to 6305d5e Compare May 25, 2021 21:13
ci/steps/brew-bump.sh Outdated Show resolved Hide resolved
@jsjoeio jsjoeio marked this pull request as ready for review May 25, 2021 21:14
@jsjoeio jsjoeio requested a review from a team as a code owner May 25, 2021 21:14
@jsjoeio jsjoeio linked an issue May 25, 2021 that may be closed by this pull request
2 tasks
@jsjoeio jsjoeio mentioned this pull request May 25, 2021
2 tasks
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #3468 (f484e69) into main (05197d5) will not change coverage.
The diff coverage is n/a.

❗ Current head f484e69 differs from pull request most recent head 8b38314. Consider uploading reports for the commit 8b38314 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3468   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05197d5...8b38314. Read the comment docs.

@jsjoeio jsjoeio force-pushed the jsjoeio/fix-3444 branch 3 times, most recently from acb992a to 1c39518 Compare June 1, 2021 23:31
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jun 1, 2021

@code-asher ready for a second review

@repo-ranger repo-ranger bot merged commit 56abc4a into main Jun 3, 2021
@repo-ranger repo-ranger bot deleted the jsjoeio/fix-3444 branch June 3, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create code-server bot account Fix homebrew step in publish workflow
2 participants