refactor: only accept string in pathToFsPath #3812
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3812 +/- ##
==========================================
+ Coverage 62.05% 62.10% +0.05%
==========================================
Files 36 36
Lines 1863 1863
Branches 378 378
==========================================
+ Hits 1156 1157 +1
+ Misses 601 600 -1
Partials 106 106
Continue to review full report at Codecov.
|
| const isWindows = process.platform === "win32" | ||
| const uri = { authority: undefined, path: getFirstString(path), scheme: "file" } | ||
| const uri = { authority: undefined, path: getFirstString(path) || "", scheme: "file" } |
There was a problem hiding this comment.
just wondering - would this be more readable in expanded form, e.g.
const uri = {
authority: undefined,
path: getFirstString(path) || "",
scheme: "file",
}I'm not sure if prettier prefers this form though
There was a problem hiding this comment.
Definitely is for me! I think Prettier autoformats it though :(
test/unit/node/util.test.ts
Outdated
| it("should not throw an error for a string array", () => { | ||
| // @ts-expect-error We need to check other types | ||
| expect(() => util.pathToFsPath(["/hello/foo", "/hello/bar"]).not.toThrow()) | ||
| }) | ||
| it("should use the first string in a string array", () => { |
There was a problem hiding this comment.
there's no more string array, right? so the description is now outdated
There was a problem hiding this comment.
Good catch! I'll update that
ugh I know 😂 I think it's cause I touched some of the routes files, but I didn't write any tests for them so it's unhappy. I'm going to say it's okay for now since at least I'm increasing coverage. |
CodeQL caught a path where we were passing in req.query.path to pathToFsPath, which may not have been a string. So we refactored some things to ensure we only pass it a string which also let us change the parameter type to string instead of string | string[].
jsjoeio
force-pushed
the
jsjoeio-fix-pathToFsPath
branch
from
aff60ef
to
6e33dcc
Compare
This PR reverts some work done in #3751 to make
pathToFsPathbetter.