Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more tests for proxy.ts #3858

Merged
merged 2 commits into from
Jul 29, 2021
Merged

feat: add more tests for proxy.ts #3858

merged 2 commits into from
Jul 29, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 26, 2021 •
edited
Loading

This PR adds more tests for proxy.ts, specifically to test that our proxy handles error events appropriately.

Fixes N/A

P.S. huge shoutout to @vapurrmaid for pairing with me on this 🎉

@codecov
Copy link

codecov bot commented Jul 26, 2021 •
edited
Loading

Codecov Report

Merging #3858 (19fa7cf) into main (7e43f7d) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 19fa7cf differs from pull request most recent head 9137816. Consider uploading reports for the commit 9137816 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3858      +/-   ##
==========================================
+ Coverage   63.40%   63.51%   +0.10%     
==========================================
  Files          36       36              
  Lines        1872     1872              
  Branches      379      379              
==========================================
+ Hits         1187     1189       +2     
+ Misses        582      580       -2     
  Partials      103      103
Impacted Files Coverage Δ
src/node/proxy.ts 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e43f7d...9137816. Read the comment docs.

@jsjoeio jsjoeio self-assigned this Jul 26, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 26, 2021

cc @code-asher would love to get your eyes on this and help me understand what I'm missing

greyscaled
greyscaled reviewed Jul 27, 2021
View reviewed changes
test/unit/proxy.test.ts Outdated Show resolved Hide resolved
@jsjoeio jsjoeio added the testing Anything related to testing label Jul 27, 2021
@jsjoeio jsjoeio added this to the 3.12.0 milestone Jul 27, 2021
jsjoeio
jsjoeio commented Jul 27, 2021
View reviewed changes
test/unit/proxy.test.ts Outdated Show resolved Hide resolved
test/unit/proxy.test.ts Outdated Show resolved Hide resolved
@jsjoeio jsjoeio marked this pull request as ready for review July 27, 2021 19:09
@jsjoeio jsjoeio requested a review from a team as a code owner July 27, 2021 19:09
@jsjoeio jsjoeio mentioned this pull request Jul 27, 2021
Closed
oxy
oxy approved these changes Jul 29, 2021
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✨

@jsjoeio jsjoeio enabled auto-merge July 29, 2021 22:17
@jsjoeio jsjoeio merged commit ff3b188 into main Jul 29, 2021
@jsjoeio jsjoeio deleted the jsjoeio-add-proxy-test branch July 29, 2021 22:33
@jsjoeio jsjoeio modified the milestones: 3.12.0, 3.11.1 Aug 6, 2021
@ahmadyahya11 ahmadyahya11 mentioned this pull request Aug 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyscaled greyscaled greyscaled approved these changes

@oxy oxy oxy approved these changes

Assignees

@jsjoeio jsjoeio

Labels
testing Anything related to testing
Projects
None yet
Milestone
3.11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jsjoeio @greyscaled @oxy