Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed version info into binary #298

Merged
merged 4 commits into from
Aug 5, 2024
Merged

feat: embed version info into binary #298

merged 4 commits into from
Aug 5, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Aug 5, 2024

Adds version info to envbuilder binary. Most of the logic is fork-lifted from coder/coder.

scripts/version.sh Outdated Show resolved Hide resolved
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably strip out more cruft that we don't want to inherit, but no major blockers for now so approving.

scripts/version.sh Outdated Show resolved Hide resolved
scripts/version.sh Outdated Show resolved Hide resolved
scripts/version.sh Outdated Show resolved Hide resolved
scripts/version.sh Outdated Show resolved Hide resolved
@johnstcn johnstcn merged commit 6d5f489 into main Aug 5, 2024
4 checks passed
@johnstcn johnstcn deleted the cj/embed-version branch August 5, 2024 11:53
johnstcn added a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants