fix: set DOCKER_CONFIG dynamically #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
commented
Sep 6, 2024
Comment on lines
-7
to
-8
| # Kaniko looks for the Docker config at $DOCKER_CONFIG/config.json | ||
| ENV DOCKER_CONFIG /.envbuilder |
There was a problem hiding this comment.
This may seem controversial, but I think it definitely makes sense to set it in code if we allow dynamically changing MagicDir.
johnstcn
force-pushed
the
cj/set-docker-config
branch
from
dc0889e
to
727a50c
Compare
dannykopping
approved these changes
Sep 9, 2024
mafredri
approved these changes
Sep 9, 2024
johnstcn
force-pushed
the
cj/set-docker-config
branch
from
727a50c
to
9ef68fb
Compare
johnstcn
added a commit
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 4547249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to coder/terraform-provider-envbuilder#43
We were not setting
DOCKER_CONFIGcorrectly, and were instead relying on having it set for us in the image. This change dynamically setsDOCKER_CONFIGat runtime instead, and removes the definition in the Envbuilder image.