Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): correctly handle devcontainer-only in cache probe mode #33

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

johnstcn
Copy link
Member

Fixes coder/envbuilder#314

Updates provider to include coder/envbuilder#315.
Updates tests to explicitly test this workflow.

@johnstcn johnstcn self-assigned this Aug 15, 2024
@@ -10,7 +10,7 @@ replace tailscale.com => github.com/coder/tailscale v1.1.1-0.20240702054557-aa55

require (
github.com/GoogleContainerTools/kaniko v1.9.2
github.com/coder/envbuilder v1.0.0-rc.0.0.20240807151028-6e5bfa5faa29
github.com/coder/envbuilder v1.0.0-rc.5.0.20240815111948-e6283db826e8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johnstcn johnstcn merged commit 9f45583 into main Aug 15, 2024
14 checks passed
@johnstcn johnstcn deleted the cj/fix-cache-probe-devcontainer-only branch August 15, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: devcontainer.Compile references global variable
2 participants