Hacks to change ant.design theme #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cesiuminho/shuriken/QKszQoV4Uf7B7YYqVqokgSupTpYf |
|
It requires so few changes that I think it's worth it. We can revert if we change our minds in the future. Maybe it will be even cleaner if Next.js gets LESS support again like this PR is proposing. |
|
I fixed the things you pointed out @nelsonmestevao. I also added the warning to the README and customized the border radius of Ant, in order to be a bit more in harmony with the Tailwind styling. I think its ready for merging. |
nelsonmestevao
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well.... Pretty much the only way I think it can be done without messing with deprecated plugins and disabling Next's built-in CSS support...
This solution is not very maintainable, but with a very obvious warning in the README I guess it could work for a while: it also has less chances of breaking current stuff and future stuff than messing around with Webpack in
next.config.jsLet me know if it's worth it to pull this. If it is I'll add the warning to the README before merging