Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE Use devtools build showing errors/warnings inline #5309

Closed

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Dec 20, 2020

Uses a version of react-devtools-inline that displays errors and warnings from React in react-devtools.

Work is mostly done over at facebook/react#20463 and now we're testing the build in various scenarios. codesandbox came to mind since that would also allow us to easier test and share repros. I saw in other PRs that you have deploy previews so that's what we're interested in right now.

Uses the latest build of react-devtools-inline from facebook/react#20463

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c91ba2c:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented Dec 20, 2020

Build for latest commit c91ba2c is at https://pr5309.build.csb.dev/s/new.

@eps1lon
Copy link
Contributor Author

eps1lon commented Dec 20, 2020

@lbogdan The deploy preview doesn't seem to work: https://pr5309.build.csb.dev/s/new?file=/src/App.js. The error looks unrelated though and locally it was working fine.

@github-actions
Copy link

This PR has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

@github-actions github-actions bot added the stale label Mar 21, 2021
@eps1lon
Copy link
Contributor Author

eps1lon commented Mar 21, 2021

Closing due to lack of interest from maintainers.

@eps1lon eps1lon closed this Mar 21, 2021
@eps1lon eps1lon deleted the devtools-show-warnings-in-tree branch March 21, 2021 13:46
@eps1lon eps1lon restored the devtools-show-warnings-in-tree branch January 24, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants