Making date fields in calender editable #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahmoud-Emad
reviewed
Feb 6, 2024
| () => [startDate.value, endDate.value], | ||
| async () => { | ||
| setTimeout(async () => { | ||
| console.log(startDateField.value.validate(), "hereeee") |
|
I think we have to calculate and display the value only if we have a valid form, else we need the user to fix the errors Screencast.from.02-06-2024.05.05.13.PM.webm |
zaelgohary
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making dates fields in calendar editable and adding validations to dates
Related Issues
#342