Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2 #66

Closed
yarikoptic opened this issue May 9, 2023 · 4 comments
Closed

Release v2 #66

yarikoptic opened this issue May 9, 2023 · 4 comments

Comments

@yarikoptic
Copy link

Please cut a new release so that fixes such as #60 become available in a released form. Otherwise we are doomed to use @master version.

yarikoptic added a commit to yarikoptic/improveit that referenced this issue May 9, 2023
v2 with the fix is not released yet and typically we should not use @master

ref: codespell-project/actions-codespell#66
@larsoner
Copy link
Member

larsoner commented May 9, 2023

https://github.com/codespell-project/actions-codespell/releases/tag/v2.0

hopefully it worked :)

@larsoner larsoner closed this as completed May 9, 2023
@per1234
Copy link
Contributor

per1234 commented May 9, 2023

@larsoner please also create a v2 tag so that we can update our workflows to a reference that only pins the major version rather than having to pin all the way to v2.0.

The action's users will start getting Dependabot PRs for the bump to the new action version in our workflows so it would be nice if those were for a v1 -> v2 bump instead of a v1 -> v2.0 bump.

More information on the reason and use of the major version ref here: #47

@yarikoptic
Copy link
Author

well, if so, may be it should have been a v1.1 release (my bad to suggest jumping right to v2) and then v1 tag was updated? Then may be v1 could be a branch (inherently mutable) to follow tags within v1.x series -- I wonder how other actions organize that flow.

@larsoner
Copy link
Member

larsoner commented May 9, 2023

Pushed a v2 that's the same as v2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants