Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the default strategy if the command is not defined in the config #4

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

jfahrer
Copy link
Collaborator

@jfahrer jfahrer commented Jul 2, 2019

No description provided.

Copy link
Member

@elsesiy elsesiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about how to test this 👍

This ensures that `donner run --strict ruby -v` works. Without the flag
urfave/cli would interpret the `-v` as part of the flags.
@jfahrer jfahrer merged commit 19a4c59 into master Jul 3, 2019
@jfahrer jfahrer deleted the default_strategy branch July 3, 2019 00:56
jfahrer added a commit that referenced this pull request Jul 10, 2019
)

* Use the default strategy if the command is not defined in the config
* Skip argument reordering
This ensures that `donner run --strict ruby -v` works. Without the flag
urfave/cli would interpret the `-v` as part of the flags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants