-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Meal Planning Calendar Events #39
Conversation
@codetheweb seems to work pretty well so far, but would love your feedback before I go too much further. Also, is there any value in merging this PR as read-only and then implementing the write operations in another PR, or would you rather I get it all working prior to merging? |
Since recipes and meal planning events seem to be closely related I think it would be better to combine the |
Since this PR is working I think it would be fine to merge it. It would make reviewing easier as well |
If you're cool with merging the read-only, so am I. But as we look at this I have another branch trying to get the write operations working. I've never used protobuf before so I'm a little out of my element. I'm looking at your code and I can see how it works but can't quite figure out how to write myself from scratch Don't suppose you could point me in the direction of something that could help? |
sorry for the late response, I'm fine with merging read-only for now |
Alright, no problem - just need to resolve your change request, but I'm not sure exactly what you're looking for. |
I actually have another idea for this. I'll submit another PR once we get through this one. |
Here it is: #42 |
Add support for Meal Planning Calendar Events.
First commit in the branch also fixes a few eslint issues that were keeping me from committing; happy to make another branch/PR for those if that helps.