Exercises and description for setTimeout and setInterval #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
| ```javascript | ||
| console.log("Wait for it..."); | ||
| __(function() { __.__(__) }, __); | ||
| // should print "NOW!" after waiting one second |
There was a problem hiding this comment.
I'd probably fill in the console.log("NOW!"), as having them type that doesn't necessarily focus on the problem at hand.
|
Overall looks 👍. Some minor nit-picky things that you can feel free to ignore. |
- Don't focus on how to log things to the console (keep focus on topic at hand) - Give a helpful name for a variable
Because who wants to wait 2 minutes to see if it works
|
Many thanks again, Zee. Merging now... |
tannerwelsh
added a commit
that referenced
this pull request
Nov 17, 2014
Exercises and description for setTimeout and setInterval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not very interesting exercises. Mostly related to timers.
Suggestions welcome.