Add button component (twig) #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatianaFomina
commented
May 11, 2022
src/frontend/svg/bin.svg
Outdated
| @@ -0,0 +1,3 @@ | |||
| <svg viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
there's something wrong with icons in figma mockups
neSpecc
reviewed
May 13, 2022
neSpecc
reviewed
May 16, 2022
| @@ -0,0 +1,86 @@ | |||
| .docs-button { | |||
| display: flex; | |||
There was a problem hiding this comment.
maybe inline-flex would be better?
| font-size: 13px; | ||
| margin-left: 10px; | ||
| margin-left: 20px; | ||
| display: inline-block; |
|
Two similar icons. Lets leave the single one.
|
TatianaFomina
commented
May 18, 2022
src/frontend/styles/vars.pcss
Outdated
| --color-button-primary-hover: #2E7AE6; | ||
| --color-button-primary-active: #296DCC; | ||
|
|
||
| --color-button-secondary: #F3F6F8; |
There was a problem hiding this comment.
btw mockups did not contain grey button example, so, i picked random grey shade. @neSpecc can you please verify the color?
neSpecc
approved these changes
May 20, 2022
nikmel2803
approved these changes
May 23, 2022
robonetphy
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configurable button "component" for twig templates.
Resolves #178