-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button component (twig) #188
Conversation
src/frontend/svg/bin.svg
Outdated
@@ -0,0 +1,3 @@ | |||
<svg viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's something wrong with icons in figma mockups
@@ -0,0 +1,86 @@ | |||
.docs-button { | |||
display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe inline-flex
would be better?
font-size: 13px; | ||
margin-left: 10px; | ||
margin-left: 20px; | ||
display: inline-block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be removed i guess
src/frontend/styles/vars.pcss
Outdated
--color-button-primary-hover: #2E7AE6; | ||
--color-button-primary-active: #296DCC; | ||
|
||
--color-button-secondary: #F3F6F8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw mockups did not contain grey button example, so, i picked random grey shade. @neSpecc can you please verify the color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I've touched your PR. I have been trying to resolve issues caused by my imperfections at the UI design process. So I've updated Figma icons and mockups itself, and then pushed new icons and dimesions to the branch to debug it.
Adds configurable button "component" for twig templates.
Resolves #178