-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change list of menus and add hover effect of menu #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Y-k-Y
As you can see in the above image.
heading's font size and padding as well as the header height are not the same as mentioned in Figma. Pls try to make pixel perfect as mentioned in Figma
need to ask design department to check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Y-k-Y, we can maintain height of the header by using padding
and line-height
CSS properties.
you can try the changes I mentioned.
@Y-k-Y I've made some changes in Figma making menu items height similar with the |
Also, the text should be Medium |
src/frontend/styles/vars.pcss
Outdated
@@ -3,6 +3,8 @@ | |||
--color-text-second: #5d6068; | |||
--color-line-gray: #E8E8EB; | |||
--color-link-active: #2071cc; | |||
--color-link-hover: #F3F6F8; | |||
--color-button-danger: #ff5159; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like an irrelevant change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only --color-button-danger
is irrelevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Resolves #179