Added ability to use custom favicon #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, added catching errors from uploadFile
neSpecc
requested changes
Jun 16, 2022
|
i don't like this idea about uploading favicon to somewhere and use its url to download it back to the server. this way it would be better to use only it's url in rc file with site's name and menu params. i think that this problem with site's config should solved with some settings page and on-boarding guide. it would be better product experience and it should be done before the release. but anyway it depends only on product owner. |
nikmel2803
reviewed
Jun 17, 2022
nikmel2803
reviewed
Jul 6, 2022
…pp.locals variables
…x.docs into feature/favicon_changing
neSpecc
reviewed
Jul 6, 2022
neSpecc
reviewed
Jul 7, 2022
neSpecc
reviewed
Jul 7, 2022
src/backend/utils/downloadFavicon.ts
Outdated
| } | ||
| }); | ||
|
|
||
| return { destination: `/favicon/favicon.${format}`, |
There was a problem hiding this comment.
strange linebreaks, use our eslint config please
There was a problem hiding this comment.
I use eslint command using config from our project, but it shows only this
eslint -c ./.eslintrc src/backend/utils/downloadFavicon.ts
neSpecc
approved these changes
Jul 7, 2022
nikmel2803
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #201