-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to use custom favicon #202
Conversation
…, added catching errors from uploadFile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a readme please, how to use it
i don't like this idea about uploading favicon to somewhere and use its url to download it back to the server. this way it would be better to use only it's url in rc file with site's name and menu params. i think that this problem with site's config should solved with some settings page and on-boarding guide. it would be better product experience and it should be done before the release. but anyway it depends only on product owner. |
…pp.locals variables
…x.docs into feature/favicon_changing
src/backend/utils/downloadFavicon.ts
Outdated
} | ||
}); | ||
|
||
return { destination: `/favicon/favicon.${format}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange linebreaks, use our eslint config please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolves #201