Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added page navigation #209

Merged
merged 18 commits into from
Aug 2, 2022
Merged

Added page navigation #209

merged 18 commits into from
Aug 2, 2022

Conversation

slaveeks
Copy link
Member

@slaveeks slaveeks commented Jul 1, 2022

resolves #177

neSpecc
neSpecc requested changes Jul 4, 2022
View reviewed changes
src/backend/routes/pages.ts Outdated Show resolved Hide resolved
src/backend/views/pages/page.twig Outdated Show resolved Hide resolved
src/frontend/styles/vars.pcss Outdated Show resolved Hide resolved
@slaveeks slaveeks requested a review from neSpecc July 6, 2022 10:25
neSpecc
neSpecc reviewed Jul 6, 2022
View reviewed changes
src/frontend/styles/components/navigator.pcss Outdated Show resolved Hide resolved
src/backend/models/pageOrder.ts Outdated Show resolved Hide resolved
@slaveeks slaveeks requested a review from neSpecc July 27, 2022 11:13
nikmel2803
nikmel2803 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@nikmel2803 nikmel2803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrode neploho 👍

it would be cool to add hotkeys for this buttons

neSpecc
neSpecc requested changes Jul 28, 2022
View reviewed changes
src/backend/models/flatArray.ts Outdated Show resolved Hide resolved
src/backend/models/flatArray.ts Outdated Show resolved Hide resolved
src/backend/models/flatArray.ts Outdated Show resolved Hide resolved
src/backend/models/flatArray.ts Outdated Show resolved Hide resolved
src/backend/models/flatArray.ts Outdated Show resolved Hide resolved
src/frontend/styles/components/page.pcss Outdated Show resolved Hide resolved
src/backend/views/components/navigator.twig Outdated Show resolved Hide resolved
src/frontend/styles/components/navigator.pcss Show resolved Hide resolved
@slaveeks slaveeks requested a review from neSpecc July 28, 2022 15:14
neSpecc
neSpecc reviewed Aug 1, 2022
View reviewed changes
src/backend/models/pagesFlatArray.ts Outdated Show resolved Hide resolved
src/backend/models/pagesFlatArray.ts Outdated Show resolved Hide resolved
src/backend/models/pagesFlatArray.ts Outdated Show resolved Hide resolved
src/backend/models/pagesFlatArray.ts Outdated Show resolved Hide resolved
src/backend/views/components/navigator.twig Outdated Show resolved Hide resolved
src/frontend/styles/components/navigator.pcss Outdated Show resolved Hide resolved
src/backend/views/pages/page.twig Outdated Show resolved Hide resolved
@slaveeks slaveeks requested a review from neSpecc August 1, 2022 13:58
@slaveeks slaveeks requested a review from neSpecc August 2, 2022 14:22
@slaveeks slaveeks merged commit 70f89f2 into main Aug 2, 2022
@nikmel2803 nikmel2803 deleted the feature/page_navigation branch December 1, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

@nikmel2803 nikmel2803 nikmel2803 approved these changes

@TatianaFomina TatianaFomina Awaiting requested review from TatianaFomina

@talyguryn talyguryn Awaiting requested review from talyguryn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: implement the navigator
3 participants
@slaveeks @neSpecc @nikmel2803