Auth fix #54
Merged
Auth fix #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 16, 2019 14:29
…docs into authentication
…en, deleted links when not authorized
…ed hidden csrf field in auth form
… comments and JSDoc
… to bcrypt.compare, added httpyOnly property to jwt cookie
…o authentication
…xistance on POST/auth
gohabereg
suggested changes
Mar 6, 2019
src/app.js
Outdated
| @@ -17,7 +17,7 @@ app.set('views', path.join(__dirname, 'views')); | |||
| app.set('view engine', 'twig'); | |||
| require('./utils/twig'); | |||
|
|
|||
| app.use(logger('dev')); | |||
| app.use(logger('dev ')); | |||
There was a problem hiding this comment.
Почему он все время ставит тут пробел?)
There was a problem hiding this comment.
У меня даже не индексировался этот файл в git status
src/routes/auth.js
Outdated
| @@ -28,6 +28,10 @@ router.get('/auth', csrfProtection, function (req, res) { | |||
| router.post('/auth', parseForm, csrfProtection, async (req, res) => { | |||
| let userDoc = await Users.get(); | |||
|
|
|||
| if (!userDoc) { | |||
| throw new Error('Password not set'); | |||
There was a problem hiding this comment.
А что будет у пользователя в этот момент?
Лучше возвращать какое-нибудь сообщение
gohabereg
approved these changes
Mar 6, 2019
neSpecc
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51