Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UniqueTranslationValidator.php #22

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Update UniqueTranslationValidator.php #22

merged 2 commits into from
Nov 30, 2022

Conversation

Tahiaji
Copy link
Contributor

@Tahiaji Tahiaji commented Nov 30, 2022

Workaround for json field and case-insensitive search. Work with mysql (not sure about another ones)

@Tahiaji
Update UniqueTranslationValidator.php
afce4c9 
Workaround for json field and case-insensitive search. 
Work with mysql (not sure about another ones)
@Tahiaji
Update UniqueTranslationValidator.php
1d84d14 
Restore backslash escape in search
@ivanvermeyen
Copy link
Contributor

Thank you for your contribution!
I changed this to a LIKE query at some point, because MySQL 5.6 didn't support JSON queries.
So I will add a new major version for this update and drop support for MySQL 5.6.
I assume most active projects will have a newer MySQL version in use by now.

@ivanvermeyen ivanvermeyen merged commit 07fd050 into codezero-be:master Nov 30, 2022
@ivanvermeyen ivanvermeyen mentioned this pull request Nov 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tahiaji @ivanvermeyen